Re: Patches for static check on geo_ops.c

From: Paul Matthews <plm(at)netspace(dot)net(dot)au>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patches for static check on geo_ops.c
Date: 2009-08-27 22:56:25
Message-ID: 4A970F19.1030706@netspace.net.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> I've applied the first three of these changes, but not the last two
> (the 'dist' assignments). "clang" seems to have a tin ear for style :-(.
> It's failing to notice that we have several similar code blocks in
> sequence in these two places, and making the last one different from the
> rest would decrease code readability and modifiability.
>
>
<voice="Maxwell Smart">"Ah! The old programming via copy-and-paste
trick"</voice>.

Maybe clang's ear for style isn't that bad after all.
:-)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-08-28 00:25:08 Re: 8.5 release timetable, again
Previous Message Josh Berkus 2009-08-27 22:35:49 Re: 8.5 release timetable, again