Skip site navigation (1) Skip section navigation (2)

Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date: 2009-08-11 16:52:37
Message-ID: 4A81A1D5.1090805@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers

Robert Haas wrote:
> I'm not sure there's a
> good solution to this problem short of making pgindent easy enough
> that we can make it a requirement for patch submission, and I'm not
> sure that's practical.
>
> But in any case, I think running pgindent immediately after the last
> CommitFest rather than after a longish delay would be a good idea.
>
>   


Frankly, fixing up patch bitrot caused by pgindent is not terribly 
difficult in my experience - bitrot caused by code drift is a much 
harder problem (and yes, git fans, I know git can help with that).

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Josh BerkusDate: 2009-08-11 17:08:39
Subject: Re: "Hot standby"?
Previous:From: Robert HaasDate: 2009-08-11 16:43:09
Subject: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

pgsql-committers by date

Next:From: Robert HaasDate: 2009-08-11 17:42:08
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Previous:From: Robert HaasDate: 2009-08-11 16:43:09
Subject: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group