Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a
Date: 2009-07-25 17:21:04
Message-ID: 4A6B3F00.7080502@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> adunstan(at)postgresql(dot)org (Andrew Dunstan) writes:
>   
>> Log Message:
>> -----------
>> Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of a magic value.
>>     
>
> This actually broke things a bit.  I agree that the original coding with
> a phony list header was horridly ugly, but it did have one redeeming
> value: namely that the various existing tests for force_quote not empty
> still worked as-is.  With the separate bool you need to extend all those
> checks.  On balance it still seems cleaner that way, though, so I made
> the necessary fixes.
>
> 			
>   

Oops! Thanks. That will teach me to code before I have my coffee.

cheers

andrew

In response to

pgsql-committers by date

Next:From: Tom LaneDate: 2009-07-25 17:50:19
Subject: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on
Previous:From: Tom LaneDate: 2009-07-25 17:07:51
Subject: Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group