Skip site navigation (1) Skip section navigation (2)

Re: GetTokenInformation() and FreeSid() at port/exec.c

From: Andrew Chernow <ac(at)esilo(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: TAKATSUKA Haruka <harukat(at)sraoss(dot)co(dot)jp>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: GetTokenInformation() and FreeSid() at port/exec.c
Date: 2009-06-23 15:07:06
Message-ID: 4A40EF9A.2030409@esilo.com (view raw or flat)
Thread:
Lists: pgsql-bugs
> 
> How about something like this? I switched to using LocalAlloc() in all
> places to be consistent, instead of mixing heap and local. (Though per
> doc, LocalAlloc is actually a wrapper for HeapAlloc in win32).

Our patches crossed.  Although, in my patch I left the allocation scheme 
alone since I wasn't sure if someone wanted that way.  I'd suggest 
malloc and free if your going to change it.  The only time I use an MS 
allocater is when a win32 api function specifically states it must be used.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

In response to

Responses

pgsql-bugs by date

Next:From: Greg StarkDate: 2009-06-23 15:08:36
Subject: Re: [BUGS] Integrity check
Previous:From: Armin JeneweinDate: 2009-06-23 15:06:15
Subject: BUG #4875: /etc/init.d/postgresql status shows postmaster is stopped when executed as user

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group