Skip site navigation (1) Skip section navigation (2)

Re: pgAgent "new step" fails for batch jobs in pgAdmin3 1.10.0 Beta 2

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Kevin Field <kevinjamesfield(at)gmail(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAgent "new step" fails for batch jobs in pgAdmin3 1.10.0 Beta 2
Date: 2009-06-10 19:51:29
Message-ID: 4A300EC1.8010903@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dave Page a écrit :
> On Tue, Jun 9, 2009 at 9:06 PM, Guillaume Lelarge<guillaume(at)lelarge(dot)info> wrote:
>>>> I think it's still useful to display the SQL, if only to allow the
>>>> user to see what pgAdmin is going to do. Disabling (better yet,
>>>> removing) the checkbox on those dialogues seems like the right answer.
>>>>
>>>> Can you do that in the next day or so?
>>>>
>>> I'll work on a patch for this tonight.
>>>
>> Here it is.
> 
> Hmm, not sure I like that - it assumes that we'll never be able to
> edit pgAgent SQL, and does so far away from the pgAgent code which
> could easily lead to future confusion.
> 
> Can we disable/hide the control on each individual dialogue please?
> 

Yes, we can. I was lazy yesterday, and didn't want to go much deeper in
the code :)

New patch is attached.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Attachment: pgagentdialogs_v2.patch
Description: text/x-patch (2.4 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2009-06-10 20:38:43
Subject: SVN Commit by guillaume: r7912 - in trunk/pgadmin3: docs docs/cs_CZ docs/cs_CZ/hints docs/cs_CZ/images pkg/win32/src
Previous:From: svnDate: 2009-06-10 17:46:54
Subject: SVN Commit by guillaume: r7911 - trunk/pgadmin3/i18n/zh_CN

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group