Skip site navigation (1) Skip section navigation (2)

Re: pgAgent "new step" fails for batch jobs in pgAdmin3 1.10.0 Beta 2

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Kevin Field <kevinjamesfield(at)gmail(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAgent "new step" fails for batch jobs in pgAdmin3 1.10.0 Beta 2
Date: 2009-06-09 20:06:49
Message-ID: 4A2EC0D9.1010308@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Guillaume Lelarge a écrit :
> Dave Page a écrit :
>> On Mon, Jun 8, 2009 at 10:23 PM, Guillaume
>> Lelarge<guillaume(at)lelarge(dot)info> wrote:
>>> Dave Page a écrit :
>>>> On Mon, May 11, 2009 at 3:43 PM, Kevin Field <kevinjamesfield(at)gmail(dot)com> wrote:
>>>>> About editing, I just tried this in the win32 beta3, and it still
>>>>> ignores the changes you make:  I went to create a new job step,
>>>>> selected batch, typed gibberish in the name and definition, unchecked
>>>>> 'read only', and erased the generated SQL and replaced it with "select
>>>>> 'hello'", and then clicked OK, and it added the gibberish step (rather
>>>>> than doing nothing, which is what select-hello should've done...)  So
>>>>> 'read only' doesn't seem to be useful at this point.
>>>> Oh, I see what you mean. If memory serves, the pgAgent dialogues
>>>> process their SQL in a slightly different way to all the other
>>>> dialogues because they need to run some parts in different steps.
>>>>
>>>> Guillaume; this is your code ( :-p ) - do you see a simple way to fix
>>>> it, or should the checkboxes be disabled on the three pgAgent
>>>> dialogues?
>>>>
>>> Actually, it's not really useful in that context. We should simply
>>> disable the checkbox on these dialogs. Perhaps we don't even need an SQL
>>> tab?
>> I think it's still useful to display the SQL, if only to allow the
>> user to see what pgAdmin is going to do. Disabling (better yet,
>> removing) the checkbox on those dialogues seems like the right answer.
>>
>> Can you do that in the next day or so?
>>
> 
> I'll work on a patch for this tonight.
> 

Here it is.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Attachment: pgagentdialogs.patch
Description: text/x-patch (593 bytes)

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2009-06-10 09:01:00
Subject: SVN Commit by dpage: r7908 - trunk/pgadmin3/pgadmin/frm
Previous:From: svnDate: 2009-06-09 17:22:39
Subject: SVN Commit by guillaume: r7907 - in trunk/www: include locale locale/cs_CZ locale/cs_CZ/LC_MESSAGES

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group