Skip site navigation (1) Skip section navigation (2)

Re: dblink patches for comment

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: dblink patches for comment
Date: 2009-06-02 03:25:06
Message-ID: 4A249B92.5080006@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>> Probably better if I break this up in logical chunks too. This patch 
>> only addresses the refactoring you requested here:
>> http://archives.postgresql.org/message-id/28719.1230996378@sss.pgh.pa.us
> 
> This looks sane to me in a quick once-over, though I've not tested it.

Thanks -- committed.

> A small suggestion for future patches: don't bother to reindent code
> chunks that aren't changing --- it just complicates the diff with a
> lot of uninteresting whitespace changes.  You can either do that after
> review, or leave it to be done by pgindent.  (Speaking of which, we
> need to schedule that soon...)

Sorry. "cvs diff -cb" seems to help (see attached). It is half the size 
and much more readable.

Joe

Attachment: dblink.2009.06.01.01-async_refactor.diff
Description: text/x-patch (4.1 KB)

In response to

pgsql-hackers by date

Next:From: Ron MayerDate: 2009-06-02 03:30:49
Subject: Re: explain analyze rows=%.0f
Previous:From: Hiroshi InoueDate: 2009-06-02 03:22:13
Subject: Re: [GENERAL] trouble with to_char('L')

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group