Re: [HACKERS] Re: BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Mikael Krantz <mk(at)zigamorph(dot)se>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Re: BUG #4796: Recovery followed by backup creates unrecoverable WAL-file
Date: 2009-05-15 11:20:26
Message-ID: 4A0D4FFA.7000705@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Fujii Masao wrote:
> Hi,
>
> On Fri, May 8, 2009 at 2:42 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> When you create a new base backup, you shouldn't need any files archived
>> before starting the backup.
>
> If so, this fix is not enough, since findNewestTimeLine() is
> still based on the premise that *all* the history files exist.
> So, as Simon says, we should clearly say that a history file
> must not be deleted from the archive. Or, we should create
> a new solution.

The probe in findNewestTimeLine() initialized to recovery target
timeline + 1. It doesn't require history files for any old timelines to
be present. The purpose of findNewestTimeLine() is to ensure that if you
e.g recover to a point in time in timeline 5, and there's already WAL
files for timelines 6 and 7 in the archive, we pick a unique timeline id.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Simon Riggs 2009-05-15 11:32:46 Re: [HACKERS] Re: BUG #4796: Recovery followed by backup creates unrecoverable WAL-file
Previous Message Fujii Masao 2009-05-15 11:11:39 Re: [HACKERS] Re: BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2009-05-15 11:32:46 Re: [HACKERS] Re: BUG #4796: Recovery followed by backup creates unrecoverable WAL-file
Previous Message Fujii Masao 2009-05-15 11:11:39 Re: [HACKERS] Re: BUG #4796: Recovery followed by backup creates unrecoverable WAL-file