Tom Lane wrote:
> Why does psql/copy.c contain this?
> #if defined(WIN32) && !defined(S_ISDIR)
> #define __S_ISTYPE(mode, mask) (((mode) & S_IFMT) == (mask))
> #define S_ISDIR(mode) __S_ISTYPE((mode), S_IFDIR)
> Surely a better place for such a thing is src/include/port/win32.h
> ... where indeed there already is a definition of S_ISDIR().
> So I think this is dead code as well as poor style. Any objection to
> seeing what happens if we remove it?
I believe that code pre-dates the full win32 port, and is from the time
when we did just libpq + psql.
So, +1 on killing it.
In response to
pgsql-hackers by date
|Next:||From: Valtonen, Hannu||Date: 2009-04-26 10:00:54|
|Subject: Patch to add support for text/int arrays for plpythonu|
|Previous:||From: tomas||Date: 2009-04-26 06:05:27|
|Subject: Re: RFE: Transparent encryption on all fields|