Re: PQinitSSL broken in some use casesf

From: Andrew Chernow <ac(at)esilo(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Merlin Moncure <mmoncure(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PQinitSSL broken in some use casesf
Date: 2009-03-30 15:07:55
Message-ID: 49D0E04B.4090606@esilo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Merlin Moncure wrote:
>> On Mon, Mar 30, 2009 at 10:22 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Mon, Mar 30, 2009 at 9:36 AM, Andrew Chernow <ac(at)esilo(dot)com> wrote:
>>>> Tom Lane wrote:
>>>>> I personally would be happy with the two-argument function solution.
>>>>>
>>>> I modified my previous patch to use a two-argument function solution.
>>> This looks OK to me, except I think we should modify the documentation
>>> to PQinitSSL() to say that it you must not use both that function and
>>> PQinitSecure(), and explain that if you need to control initialization
>>> of libcrypto and libssl, you should use that function instead.
>> do you think PQinitSSL should be deprecated?
>
> Well, I think having duplicate capability in an API is confusing, so
> yea.
>

Maybe document that PQinitSSL(do_init) is now the same as
PQinitSecure(do_init, do_init).

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Chernow 2009-03-30 15:24:01 Re: PQinitSSL broken in some use casesf
Previous Message Bruce Momjian 2009-03-30 15:05:51 Re: PQinitSSL broken in some use casesf