Re: GIN fast insert

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GIN fast insert
Date: 2009-03-24 15:13:28
Message-ID: 49C8F898.1020401@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Why is tbm_add_page() not coded as a simple wrapper around
> tbm_mark_page_lossy()? As coded, it sometimes forces a whole bunch of
> pages *other than* the target page to become lossy too, which I cannot
> see a reason for it to be doing.

[after digging in tidbitmap]
Oops, I was wrong, I supposed that all pages in chunk should be lossy, but it's
true only for chunk page. So, tbm_add_page() should only call
tbm_mark_page_lossy()...

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-03-24 15:19:30 Re: GIN fast insert
Previous Message Tom Lane 2009-03-24 14:56:17 Re: pg_dump Add dumping of comments on index columns