Re: PATCH: Update autovacuum (for TOAST-TABLE) to use reloptions, instead of a system catalog

From: Ashesh D Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Update autovacuum (for TOAST-TABLE) to use reloptions, instead of a system catalog
Date: 2009-02-24 10:00:21
Message-ID: 49A3C535.9070506@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

sure.
I will update you soon.
Should we include the toast-table AutoVacuum Settings too?

Dave Page wrote:
> On Tue, Feb 24, 2009 at 9:00 AM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> Please find the patch for (TOAST-TABLE) autovacuum settings.
>>
>> Patch contains changes for:
>> * Moved the code related to fetching the (Toast-Table) AutoVaccum settings
>> from dlgTable to pgTable.
>> * Showing AV settings (also the Toast-Table AV settings, if present) in the
>> properties listview.
>> * pgTable::GetSql() will now show custom AV settings for toast tables.
>>
>>
> Hi Ashesh,
>
> I think there is a little misunderstanding.
>
> With variables on roles and databases, if one is set, we add it to the
> properties list as an item on it's own, e.g.
>
> add_missing_from on
> log_statement all
>
> With tables, I think we should isplay the AV reloptions similarly *if*
> they are set, eg.
>
> autovacuum_enabled Yes
> autovacuum_analyze_threshold 150
> toast.autovacuum_enabled Yes
> toast.autovacuum_vacuum_cost_limit 25
>
> Can you tweak the patch accordingly please?
>
>

--
Regards,
Ashesh Vashi

EnterpriseDB INDIA: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2009-02-24 10:01:20 Re: PATCH: Update autovacuum (for TOAST-TABLE) to use reloptions, instead of a system catalog
Previous Message Dave Page 2009-02-24 09:43:52 Re: PATCH: Update autovacuum (for TOAST-TABLE) to use reloptions, instead of a system catalog