From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
Date: | 2009-02-11 11:59:29 |
Message-ID: | 4992BDA1.30506@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Note that it introduces a LEFT JOIN on pg_class to itself that's always
>> present, even for server versions that do not support reloptions.
>
> Personally I'd be more worried about the unnest(). Also, please
> schema-qualify that function name; you can't assume anything about
> the search path here.
Maybe it would be more elegant to put the search_path into proconfig?
This would have some advantages:
0. Looks less weird.
1. We could quasi-automatically verify that all SQL-language functions
have the correct search path (or even set it in initdb).
2. On things like unnest, which is a language element that we happen to
implement as a function now, you don't have to worry about it one way or
the other.
In a shell script, you'd usually set the path at the top instead of
writing out the directories of every command. It looks better (reason
0), it's easier to analyze (e.g., lintian) (reason 1), and it avoids
confusion with shell built-ins (reason 2).
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2009-02-11 14:03:43 | pgsql: Only unset the locale environment when --no-locale is used (the |
Previous Message | Bruce Momjian | 2009-02-11 04:08:47 | pgsql: Clarify PQinitSSL() documentation to mention what the argument |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-02-11 12:57:19 | Re: PQinitSSL broken in some use casesf |
Previous Message | Peter Eisentraut | 2009-02-11 10:37:20 | Re: [PATCH] Psql List Languages |