From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgevent warnings on mingw |
Date: | 2009-01-31 14:15:45 |
Message-ID: | 49845D11.6050605@hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
> I just noticed these warnings on pgevent/mingw. I guess we've probably
> been living with it for years, but it would be nice to get it clean.
> (There are also some similar warnings earlier in the build regarding
> RegisterWaitForSingleObject.)
>
> dllwrap --def pgevent.def -o pgevent.dll pgevent.o pgmsgevent.o
> Warning: resolving _DllUnregisterServer by linking to
> _DllUnregisterServer(at)0
> Use --enable-stdcall-fixup to disable these warnings
> Use --disable-stdcall-fixup to disable these fixups
> Warning: resolving _DllRegisterServer by linking to _DllRegisterServer(at)0
> Warning: resolving _DllUnregisterServer by linking to
> _DllUnregisterServer(at)0
> Use --enable-stdcall-fixup to disable these warnings
> Use --disable-stdcall-fixup to disable these fixups
> Warning: resolving _DllRegisterServer by linking to _DllRegisterServer(at)0
>
> What do we have to do to clean this stuff up?
Yeah, they've been there forever. This happened, IIRC, when we changed
the files to actually do what the documentation says. The commit message is:
"2) Change the pgevent DLL file so it doens't specify ordinal for the
functions. You're not supposed to do that. You're actually supposed to
declare them as PRIVATE as well, but mingw doesn't support that. VC++
will throw a warning and not an error though, so we can live with it.
"
The change was required to build at all with MSVC.
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | KaiGai Kohei | 2009-01-31 14:17:48 | Re: How to get SE-PostgreSQL acceptable |
Previous Message | Robert Haas | 2009-01-31 14:09:47 | Re: How to get SE-PostgreSQL acceptable |