From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Column Level Privileges |
Date: | 2009-01-30 18:48:30 |
Message-ID: | 49834B7E.1090404@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Dave Page wrote:
> - As a general rule, we disable controls not relevant to a particular
> version of Postgres. We should do the same with this tab - disable the
> controls rather than hide them on servers < 8.4.
Done
> - Can we lose the comment above the column permissions in the reverse
> engineered SQL please? We don't add similar ones for other additional
> queries so we shouldn't here (though perhaps in the future we might
> add such comments everywhere that is appropriate).
Done.
> - Not just an issue with your code, but also the existing privilege
> tabs - could you please tweak the column sizes of the list control
> such that the headers can be read by default?
Done.
Changed the column size to 70.
I think - it should fit in all the platform.
Please find the updated patch.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
ColLevelPrivileges_v2.patch | text/x-diff | 20.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2009-02-02 09:48:09 | Re: PATCH: Column Level Privileges |
Previous Message | Ashesh Vashi | 2009-01-30 17:55:11 | Re: PATCH: Column Level Privileges |