Skip site navigation (1) Skip section navigation (2)

Re: reloptions with a "namespace"

From: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
To: Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: reloptions with a "namespace"
Date: 2009-01-30 02:49:07
Message-ID: 49826AA3.8020607@timbira.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Alvaro Herrera escreveu:
> Alvaro Herrera wrote:
>> Euler Taveira de Oliveira wrote:
>>> Alvaro Herrera escreveu:
>>>> I wasn't sure of the best place to add a check.  I have added it to
>>>> transformRelOptions; I am not entirely comfortable with it, because it
>>>> works, but it still allows this:
>>>>
>>> IMHO it's the appropriate place.
>> I think the best place would be parseRelOptions.  The problem is that
>> transformRelOptions does not apply any semantics to the values it's
>> parsing; it doesn't know about the relopt_kind for example.  That stuff
>> is only known by parseRelOptions, but when the options reach that point,
>> they have already lost the namespace (due to transformRelOptions).
> 
> Okay, so I've changed things so that the transformRelOptions' caller is
> now in charge of passing an array of valid option namespaces.  This is
> working A-OK.  I'm now going to figure out appropriate pg_dump support
> and commit as soon as possible.
> 
I don't like the spreading validnsps' approach. Isn't there a way to
centralize those variables in one place, i.e., reloption.h ? Also, remove an
obsolete comment about toast tables at reloption.h.


-- 
  Euler Taveira de Oliveira
  http://www.timbira.com/

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2009-01-30 04:57:01
Subject: Re: [PATCH] Space reservation v02
Previous:From: Tom LaneDate: 2009-01-30 01:50:46
Subject: Re: Should IS DISTINCT FROM work with ANY()?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group