Skip site navigation (1) Skip section navigation (2)

Re: Git conversion progress report and call for testing assistance

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Git conversion progress report and call for testing assistance
Date: 2010-08-27 20:02:52
Message-ID: 4982.1282939372@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Fri, Aug 27, 2010 at 21:30, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> OK, the list works now, but the commitdiff links in the messages do
>> not. Looks like they are pointing at the wrong repository.

> Well, actually, they point to the right one, but the mirroring off to
> that one is turned off. There are just too many different versions
> right now to keep that thing pointing the right way :-)

Oh, OK.

In any case, you asked for feedback on the message format, so here is
some: I don't like having the commitdiff link first.  I think the log
message is the most important thing and should be first.  Possible
format (based on the example I just received):


Log Message
-----------
Another experimental commit.
Undo hacking other people previously did on README.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql-migration.git;a=commitdiff;h=1add27be08978f20edb67ca5854f6701f0f6ea86

Summary
-------
README |    4 ----
1 files changed, 0 insertions(+), 4 deletions(-)


You could argue it either way about whether to put the commitdiff link
before or after the change summary, but offhand I think before will be
more useful.  If there are a lot of files touched, people won't want
to have to scroll to the bottom to find the link.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2010-08-27 20:16:17
Subject: Re: refactoring comment.c
Previous:From: Alanoly AndrewsDate: 2010-08-27 19:57:40
Subject: Re: [HACKERS] HS/SR on AIX

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group