Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Fri, Aug 27, 2010 at 21:30, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> OK, the list works now, but the commitdiff links in the messages do
>> not. Looks like they are pointing at the wrong repository.
> Well, actually, they point to the right one, but the mirroring off to
> that one is turned off. There are just too many different versions
> right now to keep that thing pointing the right way :-)
In any case, you asked for feedback on the message format, so here is
some: I don't like having the commitdiff link first. I think the log
message is the most important thing and should be first. Possible
format (based on the example I just received):
Another experimental commit.
Undo hacking other people previously did on README.
README | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
You could argue it either way about whether to put the commitdiff link
before or after the change summary, but offhand I think before will be
more useful. If there are a lot of files touched, people won't want
to have to scroll to the bottom to find the link.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Peter Eisentraut||Date: 2010-08-27 20:16:17|
|Subject: Re: refactoring comment.c|
|Previous:||From: Alanoly Andrews||Date: 2010-08-27 19:57:40|
|Subject: Re: [HACKERS] HS/SR on AIX|