Re: mingw check hung

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: mingw check hung
Date: 2009-01-29 10:30:02
Message-ID: 4981852A.8000506@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
>
> Andrew Dunstan wrote:
>>
>>
>> Tom Lane wrote:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>
>>>> Andrew Dunstan wrote:
>>>>
>>>>> The suspect patch is quite definitely the source of the problem.
>>>>>
>>>
>>>
>>>> I can't spot the error right off :-( Can you try to see if it's the
>>>> putenv() or the unsetenv() that gets broken?
>>>>
>>>
>>> Are we sure pgwin32_unsetenv works in this environment? (Or worse,
>>> maybe it's trying to use port/unsetenv.c?)
>>>
>>>
>>
>> It is the pgwin32_unsetenv() call that is causing the trouble somehow.
>> That much I have just managed to isolate.
>>
>>
>
>
> Specifically, it's the SetEnvironmentVariable() call from
> pgwin32_putenv() called from pgwin32_unsetenv(). When this is disabled
> things work just fine.

That's strange :( What arguments are it sent to the function? Since this
is an API function, it really shouldn't behave differently between mingw
and msvc, so it must be something that goes wrong with the arguments.

Also, Tom mentioned earlier that we may be including *two* replacements
for unsetenv(), which could be what's causing the problem. Can you check
if that is happening and try to disable the one in port/unsetenv.c and
see if that changes things?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2009-01-29 10:58:13 Re: How to get SE-PostgreSQL acceptable
Previous Message Heikki Linnakangas 2009-01-29 10:22:19 Re: Hot standby, recovery infra