| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use. |
| Date: | 2009-01-22 10:10:05 |
| Message-ID: | 497845FD.3060608@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hiroshi Inoue wrote:
> Magnus Hagander wrote:
>> Peter Eisentraut wrote:
>>> Magnus Hagander wrote:
>>>> However, one question: The comment currently says it's harmless to do
>>>> this on non-windows platforms. Does this still hold true?
>>> Yes, the non-WIN32 code path appears to be the same, still. But the
>>> ifdef WIN32 part we don't want, because that presumes something about
>>> the spelling of encoding names in the local iconv library.
>>>
>>>> If we do keep the thing win32 only, I think we should just wrap the
>>>> whole thing in #ifdef WIN32 and no longer do the codeset stuff at
>>>> all on
>>>> Unix - that'll make for cleaner code.
>>> Yes, that would be much better.
>>
>> Something like this then?
>
> It seems OK to me.
Applied.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2009-01-22 17:27:55 | pgsql: Automatic view update rules Bernd Helmle |
| Previous Message | Magnus Hagander | 2009-01-22 10:09:48 | pgsql: Explicitly bind gettext to the correct encoding on Windows. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2009-01-22 10:10:39 | Re: Pluggable Indexes |
| Previous Message | Magnus Hagander | 2009-01-22 10:09:48 | pgsql: Explicitly bind gettext to the correct encoding on Windows. |