| From: | Andrew Chernow <ac(at)esilo(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Alex Hunsaker <badalex(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new libpq SSL connection option |
| Date: | 2009-01-02 14:23:15 |
| Message-ID: | 495E2353.9000201@esilo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Also, it looks like we have the same problem with the private key, in
> client_cert_cb(), agreed?
>
>
> //Magnus
>
Yeah, same issue in that function. I missed that. My grep'n was
obviously brain dead.
It almost feels like there should be some util functions like
get_sslrootcert(conn, path_buf, buf_size) for each of the SSL files.
Isolate the logic behind a function with a success or failure return
value. It would probably make the current code easier to read/follow.
Only downside is that pqGetHomeDirectory would be called twice in some
cases, but I really don't think that makes any noticeable performance
difference.
--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen R. van den Berg | 2009-01-02 14:57:46 | Re: Significantly larger toast tables on 8.4? |
| Previous Message | Peter Eisentraut | 2009-01-02 14:08:42 | Re: pg_pltemplate entries for external PLs |