Skip site navigation (1) Skip section navigation (2)

Re: Patch to handle connection limit for roles

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch to handle connection limit for roles
Date: 2008-12-31 11:00:51
Message-ID: 495B50E3.7090908@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dave Page a écrit :
> On Tue, Dec 30, 2008 at 6:36 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Hi,
>>
>> This patch handles the connection limit parameter for roles. This
>> parameter is available since 8.1 but apparently, pgAdmin doesn't handle
>> this yet.
> 
> HI,
> 
> Looks good to the eyeballs, except that as far as I can see, the patch
> assumes the user is always using 8.1 or above and will not play nicely
> with 8.0. I think you need to add a liberal smattering of 'if
> (conn->BackendMinimumVersion(8, 1))'.
> 

I assumed that pgRole and dlgRole are only used with roles (so
PostgreSQL 8.1 at least), and that pgUser and dlgUser are used with
older PostgreSQL releases. I just check this and my patch works for me
on 8.0.

Is there something I misunderstood ?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2008-12-31 11:01:56
Subject: Re: Patch to handle connection limit for roles
Previous:From: Magnus HaganderDate: 2008-12-31 10:58:12
Subject: Re: import function's progress report

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group