Re: [COMMITTERS] pgsql: Oops, don't forget to rewind the directory before scanning it to

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Greg Stark <stark(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Oops, don't forget to rewind the directory before scanning it to
Date: 2010-02-22 03:58:29
Message-ID: 4956.1266811109@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> + Free(xldir);

> s/Free/FreeDir ?

Yeah, that too. I think it's all good now, but please test.

One thing I was wondering was whether the stat-wrong-file problem
could explain the buildfarm failures that we thought were evidence
of a portability issue. I was tempted to re-enable the #ifdef NOTYET
code, but didn't want to pull that trigger while there were other
problems outstanding.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2010-02-22 07:59:36 Re: [COMMITTERS] pgsql: Oops, don't forget to rewind the directory before scanning it to
Previous Message Tom Lane 2010-02-22 02:54:40 Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-02-22 04:47:03 Re: Streaming replication on win32, still broken
Previous Message Tom Lane 2010-02-22 03:28:28 Time travel on the buildfarm