| From: | Robert Lor <Robert(dot)Lor(at)Sun(dot)COM> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DTrace probes patch |
| Date: | 2008-12-22 16:35:41 |
| Message-ID: | 494FC1DD.1090308@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Robert Lor <Robert(dot)Lor(at)Sun(dot)COM> writes:
>
>> Tom Lane wrote:
>>
>>> I agree. If the probe is meant to track only *some* WAL writes
>>> then it needs to be named something less generic than
>>> TRACE_POSTGRESQL_WAL_BUFFER_WRITE.
>>>
>>>
>> How about change it to TRACE_POSTGRESQL_WAL_BUFFER_WRITE_DIRTY similar to TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY for shared buffers?
>>
>
> Works for me...
>
>
Attached is the patch for the above name change.
-Robert
| Attachment | Content-Type | Size |
|---|---|---|
| probe-name-change.patch | text/plain | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-12-22 16:52:05 | Some semantic details of the window-function spec |
| Previous Message | Alvaro Herrera | 2008-12-22 16:24:53 | Re: generic reloptions improvement |