Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any
Date: 2008-12-20 09:44:25
Message-ID: 494CBE79.9060904@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Tom Lane wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
>> Log Message:
>> -----------
>> SQL/MED catalog manipulation facilities
> 
> The buildfarm says this patch has got serious portability issues.
> 
> grebe, dugong, and ermine are all crashing here:
> 
> --- 109,115 ----
>   (3 rows)
>   
>   ALTER FOREIGN DATA WRAPPER foo OPTIONS (a '1', b '2');
> ! server closed the connection unexpectedly
> ! 	This probably means the server terminated abnormally
> ! 	before or while processing the request.
> ! connection to server was lost
> 
> (Unfortunately I can't reproduce this on any of my own machines.)

Neither can I. All the non-Windows crashes in the buildfarm seem to be 
on 64-bit machines, although not all 64-bit members crash.

The callers of transformGenericOptions-function in foreigncmds.c use 
OidIsValid to check the return value of transformGenericOptions, but it 
returns an array, not an Oid. I committed a fix for that, we'll see if 
it heals the buildfarm.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Bryce CuttDate: 2008-12-20 10:58:37
Subject: Re: Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets
Previous:From: Heikki LinnakangasDate: 2008-12-20 09:40:56
Subject: pgsql: Don't use OidIsValid to check the return value of

pgsql-committers by date

Next:From: User AchernowDate: 2008-12-20 13:04:44
Subject: libpqtypes - libpqtypes: cranked the output buffer for PQputvf in
Previous:From: Heikki LinnakangasDate: 2008-12-20 09:40:56
Subject: pgsql: Don't use OidIsValid to check the return value of

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group