Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Append major version number and for libraries soname major

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Dave Page <dpage(at)pgadmin(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Append major version number and for libraries soname major
Date: 2008-12-16 15:43:22
Message-ID: 4947CC9A.6010609@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>   
>> Dave Page wrote:
>>     
>>> Any eta on a fix for this? My internal builds are failing as well as
>>> red_bat. (and yes, the other 2 MSVC buildfarm members are currently
>>> waiting for Dell to get hold of a new motherboard for their box).
>>>       
>
>   
>> I think the maintenance of the MSVC build system is the job of the, 
>> well, maintainer of the MSVC build system, whoever that may be.  In 
>> other words, I have no ETA for you from me.  I'd be glad, however, to 
>> provide information to the maintainers.
>>     
>
> I do not think this is an appropriate attitude for a committer to take.
> You are responsible for what you commit.  If you don't have the
> knowledge to fix something, or the resources to test it, okay ... but
> you then need to be proactive about getting someone else to fix/test it.
> Or else revert the broken patch.
>
>
>   

I agree. I have committed an attempted fix which I discussed briefly 
with Magnus.

cheers

andrew

In response to

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2008-12-16 15:57:56
Subject: Re: SQL/MED compatible connection manager
Previous:From: Tom LaneDate: 2008-12-16 14:56:24
Subject: Re: [BUG?] UPDATE with RETURNING tableoid

pgsql-committers by date

Next:From: Tom LaneDate: 2008-12-16 16:26:08
Subject: pgsql: Make heap_update() set newtup->t_tableOid correctly, for
Previous:From: Andrew DunstanDate: 2008-12-16 15:42:21
Subject: pgsql: Attempt to fix MSVC breakage from Major Version patch.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group