Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Append major version number and for libraries soname major

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Append major version number and for libraries soname major
Date: 2008-12-16 10:47:43
Message-ID: 4947874F.4010306@gmx.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Dave Page wrote:
> On Fri, Dec 12, 2008 at 12:41 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
>>> Log Message:
>>> -----------
>>> Append major version number and for libraries soname major version number
>>> to the gettext domain name, to simplify parallel installations.
>> The results from buildfarm member red_bat suggest that this commit broke
>> the MSVC build.  (I think that is the only MSVC buildfarm member that's
>> up at the moment.)
>>
>> Build FAILED.
>> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
>> .\src\backend\main\main.c(90): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
>> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
>>    0 Warning(s)
>>    3 Error(s)
> 
> Any eta on a fix for this? My internal builds are failing as well as
> red_bat. (and yes, the other 2 MSVC buildfarm members are currently
> waiting for Dell to get hold of a new motherboard for their box).

I think the maintenance of the MSVC build system is the job of the, 
well, maintainer of the MSVC build system, whoever that may be.  In 
other words, I have no ETA for you from me.  I'd be glad, however, to 
provide information to the maintainers.

The fix here is to define PG_MAJORVERSION near whereever you define 
PG_VERSION, just make it look like "8.4" instead of "8.4devel".

In response to

Responses

pgsql-hackers by date

Next:From: Dave PageDate: 2008-12-16 11:01:45
Subject: Re: pgsql: Append major version number and for libraries soname major
Previous:From: A. KretschmerDate: 2008-12-16 10:29:02
Subject: Re: non unique value error... pgsql,,help needed.

pgsql-committers by date

Next:From: Dave PageDate: 2008-12-16 11:01:45
Subject: Re: pgsql: Append major version number and for libraries soname major
Previous:From: Dave PageDate: 2008-12-16 10:13:01
Subject: Re: pgsql: Append major version number and for libraries soname major

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group