Andrew Chernow wrote:
> If it previously worked without threads, than in theory a deep copy of
> the thread_arg should fix the core dump; especially if the non-windows
> fork() method works with this patch. Maybe you can get away with only
> copying some of the members (trial-n-error), I don't think they are
> all being used in this context. Nothing should be copied from within
> the thread itself.
I did this, but it turned out that the problem was a logic error that I
found once I had managed to get a working debugger. However, the Windows
thread code should now be more robust, so thanks to Andrew and Magnus
for the suggestions.
This version completes properly on Windows with the regression database.
Left to do:
. improve error checking
. memory leak cleanup
. code cleanup
I hope to have this done shortly.
In response to
pgsql-hackers by date
|Next:||From: Mark Mielke||Date: 2008-12-14 17:57:24|
|Subject: Re: Sync Rep: First Thoughts on Code|
|Previous:||From: Hitoshi Harada||Date: 2008-12-14 17:00:26|
|Subject: Re: Windowing Function Patch Review -> Standard Conformance|