Bruce Momjian wrote:
> Kris Jurka wrote:
>> Magnus Hagander wrote:
>>> Log Message:
>>> -----------
>>> Properly unregister OpenSSL callbacks when libpq is done with
>>> it's connection. This is required for applications that unload
>>> the libpq library (such as PHP) in which case we'd otherwise
>>> have pointers to these functions when they no longer exist.
>> Breaks the build with --enable-thread-safety and --with-openssl because 
>> of this typo.
> 
> Thanks, applied.

That fix is wrong.

The comment clearly says the code *shouldn't* free the lockarray, so the
proper fix is to remove those two lines.

I have applied a patch that does this.

//Magnus

In response to

• Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with at 2008-12-04 02:52:39 from Bruce Momjian

pgsql-hackers by date

Next:	From: Gregory Stark	Date: 2008-12-04 14:09:34
	Subject: Re: Optimizing DISTINCT with LIMIT
Previous:	From: Gregory Stark	Date: 2008-12-04 13:48:05
	Subject: Re: In-place upgrade: catalog side

pgsql-committers by date

Next:	From: Alvaro Herrera	Date: 2008-12-04 14:51:02
	Subject: pgsql: Fix a couple of snapshot management bugs in the new ResourceOwner
Previous:	From: Magnus Hagander	Date: 2008-12-04 14:07:42
	Subject: pgsql: Comment said we don't free the lockarray, and why.