Skip site navigation (1) Skip section navigation (2)

Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Kris Jurka <books(at)ejurka(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with
Date: 2008-12-04 14:08:13
Message-ID: 4937E44D.6070008@hagander.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Bruce Momjian wrote:
> Kris Jurka wrote:
>> Magnus Hagander wrote:
>>> Log Message:
>>> -----------
>>> Properly unregister OpenSSL callbacks when libpq is done with
>>> it's connection. This is required for applications that unload
>>> the libpq library (such as PHP) in which case we'd otherwise
>>> have pointers to these functions when they no longer exist.
>> Breaks the build with --enable-thread-safety and --with-openssl because 
>> of this typo.
> 
> Thanks, applied.

That fix is wrong.

The comment clearly says the code *shouldn't* free the lockarray, so the
proper fix is to remove those two lines.

I have applied a patch that does this.

//Magnus


In response to

pgsql-hackers by date

Next:From: Gregory StarkDate: 2008-12-04 14:09:34
Subject: Re: Optimizing DISTINCT with LIMIT
Previous:From: Gregory StarkDate: 2008-12-04 13:48:05
Subject: Re: In-place upgrade: catalog side

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2008-12-04 14:51:02
Subject: pgsql: Fix a couple of snapshot management bugs in the new ResourceOwner
Previous:From: Magnus HaganderDate: 2008-12-04 14:07:42
Subject: pgsql: Comment said we don't free the lockarray, and why.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group