Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Kris Jurka <books(at)ejurka(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with
Date: 2008-12-04 14:08:13
Message-ID: 4937E44D.6070008@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian wrote:
> Kris Jurka wrote:
>> Magnus Hagander wrote:
>>> Log Message:
>>> -----------
>>> Properly unregister OpenSSL callbacks when libpq is done with
>>> it's connection. This is required for applications that unload
>>> the libpq library (such as PHP) in which case we'd otherwise
>>> have pointers to these functions when they no longer exist.
>> Breaks the build with --enable-thread-safety and --with-openssl because
>> of this typo.
>
> Thanks, applied.

That fix is wrong.

The comment clearly says the code *shouldn't* free the lockarray, so the
proper fix is to remove those two lines.

I have applied a patch that does this.

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2008-12-04 14:51:02 pgsql: Fix a couple of snapshot management bugs in the new ResourceOwner
Previous Message Magnus Hagander 2008-12-04 14:07:42 pgsql: Comment said we don't free the lockarray, and why.

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2008-12-04 14:09:34 Re: Optimizing DISTINCT with LIMIT
Previous Message Gregory Stark 2008-12-04 13:48:05 Re: In-place upgrade: catalog side