Skip site navigation (1) Skip section navigation (2)

Re: Patch for "Panel for Joins in the Graphic Query Builder"

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"
Date: 2008-12-03 10:42:23
Message-ID: 4936628F.5090808@enterprisedb.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi,

Please find the updated patch.

>> - The Join label doesn't update on the diagram if you change the join
>> type unless you click on the drawing canvas afterwards.
>>
>> Done
>> Only issue, I can see with the combobox within the Grid, is until you loose
>> the focus
>> (by either pressing return or moving to other cell), the value is not
>> getting updated
>> for that particular join
>>     
>
> I don't see any difference on Windows - I still need to click on the
> canvas before the label changes. Changing to a difference cell, or
> hitting return doesn't help.
>   
Done.
> I spotted another minor issue - if I'm on the Joins tab, and I click
> the Columns tab - the main tab set at the top switches to SQL Editor!
>   
I think - this is a bug from a while, I can reproduce the same for the 
"Criteria Panel".
If I make any changes in the "Criteria Panel", and then click "Columns 
Panel", the main
tab set at the top switches to "SQL Editor". :(

I will send a patch for it.

Thanks Luis for your help.
Your changes are also included in this patch.

Regards,
Ashesh


Attachment: GQBJoinsPanel_v3.patch
Description: text/x-patch (47.1 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2008-12-03 15:59:24
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"
Previous:From: Ashesh VashiDate: 2008-12-03 10:13:51
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group