Re: [REVIEW] (was Re: usermap regexp support)

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Gianni Ciolli <gianni(dot)ciolli(at)2ndquadrant(dot)it>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [REVIEW] (was Re: usermap regexp support)
Date: 2008-11-28 13:10:25
Message-ID: 492FEDC1.8030804@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Gianni Ciolli wrote:
> On Tue, Nov 11, 2008 at 02:59:01PM +0100, Magnus Hagander wrote:
>> Gianni Ciolli wrote:
>>> WARNING: detected write past chunk end in Postmaster 0x9b13650
>> Yes, that's a stupid bug:
> (...)
>> Attached is an updated version of the patch that fixes this.
>
> Hi Magnus,
>
> please find below the review of the second version of your patch,
> which I think is "Ready for Committer" now.

Thanks for a very thorough review! I'll incorporate your suggested
changes and do a commit soon.

> = En-passant remarks =
>
> * I found out that the comments in the pg_hba.conf file installed by
> default are obsolete; we should either update them or replace them
> with a reference to the Manual, chapter "Client Authentication",
> section "the pg_hba.conf file".

I'll update the hba file for now - moving it to the manual and just
reference that is outside the scope of this patch.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2008-11-28 13:42:39 Re: PLUGINS Functionlity in Win32 build scripts
Previous Message Alvaro Herrera 2008-11-28 13:08:12 Re: HEAD build failure on win32 mingw