Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

From: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
To: Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.
Date: 2008-11-27 14:26:01
Message-ID: 492EADF9.20804@tpf.co.jp (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Magnus Hagander wrote:
> On 25 nov 2008, at 05.00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> 
>> Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> writes:
>>> Tom Lane wrote:
>>>> If that's true then this code is presently broken for *every* locale
>>>> under Windows, not only Japanese.
>>
>>> Maybe there are a few languages/countires where 2 encodings are
>>> widely used.
>>
>> UTF8 vs Latin-N?
> 
> We already special-cases utf8...
> 
> I think the thing us that as long as the encodings are compatible 
> (latin1 with different names for example) it worked  fine.
> 
>>  In any case I think the problem is that gettext is
>> looking at a setting that is not what we are looking at.  Particularly
>> with the 8.4 changes to allow per-database locale settings, this has
>> got to be fixed in a bulletproof way.

Attached is a new patch to apply bind_textdomain_codeset() to most
server encodings. Exceptions are PG_SQL_ASCII, PG_MULE_INTERNAL
and PG_EUC_JIS_2004. "EUC-JP" may be OK for EUC_JIS_2004.

Unfortunately it's hard for Saito-san and me to check encodings
other than EUC-JP.

regards,
Hiroshi Inoue

Attachment: mbutils.patch
Description: text/plain (2.1 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2008-11-27 14:41:04
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1
Previous:From: Jaime CasanovaDate: 2008-11-27 14:01:56
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2008-11-27 15:59:28
Subject: pgsql: Fix obsolete comment regarding FSM truncation.
Previous:From: Heikki LinnakangasDate: 2008-11-27 13:32:26
Subject: pgsql: Don't force creation of the FSM on searches.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group