| From: | Benedek László <laci(at)benedekl(dot)tvnetwork(dot)hu> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, ibrar(dot)ahmad(at)gmail(dot)com |
| Subject: | Re: pg_dump roles support |
| Date: | 2008-11-13 23:31:04 |
| Message-ID: | 491CB8B8.3060706@benedekl.tvnetwork.hu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2008-11-08 09:25, Benedek László wrote:
>> Does this work if the role name contains a ' ?
>
> Right, this one fails with ' in the role name. An update coming soon
> closing this issue.
>
Here is an updated patch, which deals with 's in the rolename.
Please review.
doc/src/sgml/ref/pg_dump.sgml | 16 +++++++++
doc/src/sgml/ref/pg_dumpall.sgml | 15 ++++++++
src/bin/pg_dump/pg_backup.h | 2 +
src/bin/pg_dump/pg_backup_archiver.c | 35 ++++++++++++++++++-
src/bin/pg_dump/pg_dump.c | 60
+++++++++++++++++++++++++++++++++-
src/bin/pg_dump/pg_dumpall.c | 23 +++++++++++++
6 files changed, 148 insertions(+), 3 deletions(-)
Thank you, regards
Benedek Laszlo
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump_role.patch | text/x-patch | 11.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2008-11-13 23:53:37 | Re: Simple postgresql.conf wizard |
| Previous Message | Tom Lane | 2008-11-13 23:12:00 | Re: array_agg and array_accum (patch) |