Skip site navigation (1) Skip section navigation (2)

Re: Buglets in dlgFunction

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Buglets in dlgFunction
Date: 2008-11-06 23:15:55
Message-ID: 49137AAB.3010806@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dave Page a écrit :
> [...]
> On Mon, Oct 27, 2008 at 8:23 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> Thanks. I still don't like this hack. I hope I'll soon better understand
>>> this issue to replace the ugly code with a good one.
>> You're going to hate this - but I just tested Gevik's work on Windows,
>> and seem to be seeing the SQL and Privilege panes mis-behaving there
>> :-(
>>
>> I wonder if we just need to defer the restoration of the dialogue size
>> to a much later time than it currently is done. Obviously we could
>> just do it at the point that you have your hack at the moment, but it
>> would be nice to do it in the base class. I tried doing this quickly
>> but didn't get too far.

I tried it and it failed.

>> Putting your existing hack towards the end of
>> dlgProperty::Go (but without the WXMAC ifdef) seemed to do the job
>> though - albeit still hackily.
>>
>> Thoughts?
>>

Still a hack but it works. It even works with GTK. The patch attached
removes the WXMAC ifdef.

>> I also found on Windows that the check boxes for different privileges
>> on the privilege panes are touching each other and could use some
>> spacing. Can you look at that please?
>>

I forgot to add a border to the checkboxes. I tried from 4 to 1. 4 was
really big. I still hesitate between 1 et 2. 2 seems better, so that's
the value in the patch. I think you should try both of them and tell us
which one you prefer.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Attachment: winguiglitches_v1.patch
Description: text/x-patch (5.9 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2008-11-07 14:48:56
Subject: SVN Commit by dpage: r7497 - in trunk/pgadmin3: . pgadmin/dlg pgadmin/include/schema pgadmin/schema
Previous:From: Dave PageDate: 2008-11-05 22:42:55
Subject: Re: Buglets in dlgFunction

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group