Re: Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

Brendan Jurd wrote:
> ...Sep 18, 2008...Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com> wrote:
>> (1) ...GUC called "IntervalStyle"...
>> (2) ...interval style that will match the SQL standards...
>
> ...an initial review...
>
> When I ran the regression tests, I got one failure in the new interval

Fixed, and I did a bit more testing both with and without HAVE_INT64_TIMESTAMP.

> The C code has some small stylistic inconsistencies; ...
> ... spaces around binary operators are missing (e.g., "(fsec<0)").

Thanks. Fixed these.

> ...function calls missing the space after the argument separator...

I think I fixed all these now too.

> The new documentation is good in terms of content, but there are some
> minor stylistic and spelling cleanups I would suggest.
> ...variously..."SQL standard", "SQL-standard" and "SQL Standard"...

Got it. There are a few inconsistencies elsewhere in the file
talking about other data types. I wonder if I should fix those
as well.

> These sentences in datatype.sgml are a bit awkward ...
> I would go with something more along the lines of...

Yes. Thanks for the better wording.

> I don't think "old releases" is specific enough.

Yup - fixed that too.

> That's all the feedback I have for the moment. I hope you found my
> comments helpful. I'll be setting the status of this patch to
> "Returned with Feedback" and wait for your responses before I move
> forward with reviewing the other patches.

Great. I've tried to update the style on my remaining patches as well.

In addition, I've added to the docs describing how I use
explicit '+' and '-' signs to disambiguate the mixed-sign
non-standard intervals when in the sql_standard mode.

As before the 3 patches are at: http://0ape.com/postgres_interval_patches/
and http://git.forensiclogic.com/postgresql/ and
http://git.forensiclogic.com/?p=postgresql;a=shortlog;h=refs/heads/cleanup

I'm attaching the patch dealing with sql standard intervals here for the archives.