Re: Re: Updated interval patches (SQL std output, ISO8601 intervals, and interval rounding)

From: Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Re: Updated interval patches (SQL std output, ISO8601 intervals, and interval rounding)
Date: 2008-11-01 04:42:23
Message-ID: 490BDE2F.5040306@cheapcomplexdevices.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ron Mayer wrote:
> Ron Mayer wrote:
>> Ron Mayer wrote:
>> > Tom Lane wrote:
>> >> In fact, given that we are now
>> >> somewhat SQL-compliant on interval input, a GUC that selected
>> >> PG traditional, SQL-standard, or ISO 8601 interval output format
>> seems
>> >> like it could be a good idea.
>>
>> Attached are updated versions of the Interval patches ...

# Patch 3: "cleanup.patch"
Fix rounding inconsistencies and refactor interval input/output code

This patch removes a lot of copy & paste with gratuitous rounding
inconsistencies in the old interval code. This patch refactors it to save
about 300 lines in datetime.c, and by reusing code (instead of the
near-copy-paste that was there before) helps insure that rounding
inconsistancies are avoided.

It removes almost as much code as the other two patches added.

This patch applies on top of patch 1 and 2 posted up-thread..

My apologies if you got these twice, my mailer seems to be rejecting
even slightly large attachments so I tried a couple times.

During the commit-fest I'll post versions of these that are regularly
synced with CVS HEAD here: http://0ape.com/postgres_interval_patches/
along with a combined patch that includes all 3 of these in a single patch.

Attachment Content-Type Size
cleanup.patch.gz application/x-gzip 12.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2008-11-01 12:17:12 Re: pgsql: Allow SQL-language functions to return the output of an
Previous Message Hannu Krosing 2008-11-01 04:13:30 Enable pl/python to return records based on multiple OUT params