| From: | Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: contrib/pg_stat_statements |
| Date: | 2008-10-30 18:44:56 |
| Message-ID: | 490A00A8.7050708@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
ITAGAKI Takahiro wrote:
>> But is the idea of extending QueryDesc generally acceptable? Is it OK
>> to make a copy of the query string?
>
> The only thing I'm worried about is that QueryDesc lives longer than
> its queryText. Can I assume it never occurs?
>
I just finished validating this -- it seems OK. All of the query strings
that make it to CreateQueryDesc are either pstrdup-ed to Portal, in long
lived memory context or just literals. So no need to make extra copies :)
regards,
Martin
| Attachment | Content-Type | Size |
|---|---|---|
| querydesc.patch | text/x-diff | 10.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2008-10-30 18:52:59 | Re: Decreasing WAL size effects |
| Previous Message | Martijn van Oosterhout | 2008-10-30 18:34:26 | Re: Block-level CRC checks |