| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kenneth Marshall <ktm(at)rice(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: minimal update |
| Date: | 2008-10-29 20:36:06 |
| Message-ID: | 4908C936.4070105@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
>
> David Fetter wrote:
>>>
>>> Maybe we should fix our C sample trigger, from which this was taken.
>>>
>>
>> Yes :)
>>
>> Does the attached have the right error code?
>>
>> - elog(ERROR, "trigf: not called by trigger manager");
>> + ereport(ERROR,
>> + (error(TRIGGERED_DATA_CHANGE_VIOLATION),
>> + errmsg("trigf: not called by trigger manager")));
>>
>>
>
> Not sure that's appropriate, but I can't see anything else that is
> very appropriate either.
The plpgsql code uses errcode(ERRCODE_FEATURE_NOT_SUPPORTED) for this
situation, so I guess we should be consistent with that.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-10-29 20:43:06 | Re: PostgreSQL network discovery |
| Previous Message | Andrew Dunstan | 2008-10-29 20:20:15 | Re: minimal update |