Skip site navigation (1) Skip section navigation (2)

Re: minimal update

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: David Fetter <david(at)fetter(dot)org>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kenneth Marshall <ktm(at)rice(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minimal update
Date: 2008-10-29 20:36:06
Message-ID: 4908C936.4070105@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
>
> David Fetter wrote:
>>>
>>> Maybe we should fix our C sample trigger, from which this was taken.
>>>     
>>
>> Yes :)
>>
>> Does the attached have the right error code?
>>
>> -        elog(ERROR, "trigf: not called by trigger manager");
>> +        ereport(ERROR,
>> +                (error(TRIGGERED_DATA_CHANGE_VIOLATION),
>> +                 errmsg("trigf: not called by trigger manager")));
>>
>>   
>
> Not sure that's appropriate, but I can't see anything else that is 
> very appropriate either.


The plpgsql code uses errcode(ERRCODE_FEATURE_NOT_SUPPORTED) for this 
situation, so I guess we should be consistent with that.

cheers

andrew


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-10-29 20:43:06
Subject: Re: PostgreSQL network discovery
Previous:From: Andrew DunstanDate: 2008-10-29 20:20:15
Subject: Re: minimal update

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group