| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Kris Jurka <books(at)ejurka(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Any reason to have heap_(de)formtuple? |
| Date: | 2008-10-29 05:58:23 |
| Message-ID: | 4907FB7F.8070807@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kris Jurka napsal(a):
>
>
> On Tue, 28 Oct 2008, Zdenek Kotala wrote:
>
>> Kris Jurka napsal(a):
>>>
>>> Here's a patch that changes everything over to the the new API and
>>> implements the old API by calling the new API.
>>
>> It seems to me OK. I have only one comment. I prefer to pfree
>> allocated memory for temporary nulls array. I think that caller could
>> call old API many times without memory context cleanup.
>>
>
> Here's an incremental patch to add the suggested pfreeing.
I think it is ready to commit now.
Thanks Zdenek
--
Zdenek Kotala Sun Microsystems
Prague, Czech Republic http://sun.com/postgresql
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2008-10-29 06:13:20 | Re: Decreasing WAL size effects |
| Previous Message | Joshua D. Drake | 2008-10-29 05:16:12 | Re: PostgreSQL + Replicator developer meeting 10/28 |