Skip site navigation (1) Skip section navigation (2)

Re: Any reason to have heap_(de)formtuple?

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Any reason to have heap_(de)formtuple?
Date: 2008-10-28 20:44:46
Message-ID: 490779BE.90401@sun.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Kris Jurka napsal(a):
> 
> 
> On Thu, 23 Oct 2008, Kris Jurka wrote:
> 
>> The problem with trying to deprecate it is that the vast majority of 
>> the backend is still using the old interfaces, so people looking for 
>> inspiration for their external modules will likely end up using the 
>> old interface.  Like Alvaro I started this conversion a while ago, got 
>> bored, and forgot about it. If people do want this conversion done 
>> while keeping the old interface around, I can track down that patch, 
>> update it and finish it up for the next CommitFest.
>>
> 
> Here's a patch that changes everything over to the the new API and 
> implements the old API by calling the new API.

It seems to me OK. I have only one comment. I prefer to pfree allocated memory 
for temporary nulls array. I think that caller could call old API many times 
without memory context cleanup.


		Zdenek



-- 
Zdenek Kotala              Sun Microsystems
Prague, Czech Republic     http://sun.com/postgresql


In response to

Responses

pgsql-hackers by date

Next:From: Devrim GÜNDÜZDate: 2008-10-28 20:48:24
Subject: Re: PostgreSQL + Replicator developer meeting 10/28
Previous:From: Alvaro HerreraDate: 2008-10-28 20:36:15
Subject: Re: Re: [COMMITTERS] pgsql: Rework subtransaction commitprotocol for hot standby.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group