Skip site navigation (1) Skip section navigation (2)

Re: Compiler warnings in psqloodbc 08.03.0200

From: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
To: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
Cc: Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, pgsql-odbc(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>
Subject: Re: Compiler warnings in psqloodbc 08.03.0200
Date: 2008-09-30 21:41:01
Message-ID: 48E29CED.8000801@tpf.co.jp (view raw or flat)
Thread:
Lists: pgsql-odbc
Zoltan Boszormenyi wrote:
> Hi,
> 
> here's the fix for all non-pointer-signedness warnings,
> against 08.03.0300 that was released meanwhile. Now
> the compilation only emits 246 "differ in signedness"
> warnings, which is still too much noise. I agree with
> Tom Lane that those should be cleaned up if for nothing
> else, than the real bugs don't get lost in the noise.

Thanks.

> In pgapi30.c, two instances of
> "cast from pointer to integer of different size"

They may come from the strange handling of unixODBC's
64bit ODBC. Honestly I don't understand how to use
64-bit unixODBC correctly. Probably you can remove the
  warnings by #defining BUILD_REAL_64_BIT_MODE somewhere.

> In psqlodbc.c()::finalize_global_cs() is only used inside
> "#ifdef WIN32" but was defined outside causing a
> "defined but not used" warning.

It is also used in _fini() when __GNUC__ isn't defined.
Though I'm not familiar with *nix systems, it seems
strange to me that there's no function with
__attribute__((destructor)) while init() function
with __attribute__((constrcutor)) is used under
  __GNUC__ mode.

In response to

Responses

pgsql-odbc by date

Next:From: Zoltan BoszormenyiDate: 2008-10-01 05:28:27
Subject: Re: Compiler warnings in psqloodbc 08.03.0200
Previous:From: Zoltan BoszormenyiDate: 2008-09-30 16:56:21
Subject: Re: Compiler warnings in psqloodbc 08.03.0200

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group