Andrew Dunstan wrote:
> Magnus Hagander wrote:
>> I had a chat with Heikki about this, and the proper way to fix it.
>> Should there actually be any reason not to *always* open our files with
>> O_BINARY? That seems to be what should mimic what Unix does, which would
>> be what we expect, no?
>> If that is so, then I propose we do that for 8.4, and just backpatch the
>> O_BINARY flag to these two locations for 8.3 and 8.2. Thoughts?
> ISTR there are a few places where we want CRLF translation (config files?)
These seem to be using fopen() (through AllocateFile()), which wouldn't
be affected by this.
> I'd be fairly conservative about making changes like this.
This is why my proposal would be not to backpatch such a change, but to
only do it for 8.4.
In response to
pgsql-hackers by date
|Next:||From: Zdenek Kotala||Date: 2008-09-19 14:44:04|
|Subject: Re: FSM patch - performance test|
|Previous:||From: Scott Marlowe||Date: 2008-09-19 14:39:14|
|Subject: Re: Regaining superuser access|
pgsql-bugs by date
|Next:||From: Taras Kopets||Date: 2008-09-20 08:26:24|
|Subject: BUG #4428: renaming tables, columns and fk cheks problem|
|Previous:||From: Andrew Dunstan||Date: 2008-09-19 14:38:22|
|Subject: Re: [HACKERS] 0x1A in control file on Windows|