| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] 0x1A in control file on Windows |
| Date: | 2008-09-19 14:42:07 |
| Message-ID: | 48D3BA3F.5040802@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
>> I had a chat with Heikki about this, and the proper way to fix it.
>>
>> Should there actually be any reason not to *always* open our files with
>> O_BINARY? That seems to be what should mimic what Unix does, which would
>> be what we expect, no?
>>
>> If that is so, then I propose we do that for 8.4, and just backpatch the
>> O_BINARY flag to these two locations for 8.3 and 8.2. Thoughts?
>>
>>
>>
>
> ISTR there are a few places where we want CRLF translation (config files?)
These seem to be using fopen() (through AllocateFile()), which wouldn't
be affected by this.
> I'd be fairly conservative about making changes like this.
This is why my proposal would be not to backpatch such a change, but to
only do it for 8.4.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Taras Kopets | 2008-09-20 08:26:24 | BUG #4428: renaming tables, columns and fk cheks problem |
| Previous Message | Andrew Dunstan | 2008-09-19 14:38:22 | Re: [HACKERS] 0x1A in control file on Windows |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2008-09-19 14:44:04 | Re: FSM patch - performance test |
| Previous Message | Scott Marlowe | 2008-09-19 14:39:14 | Re: Regaining superuser access |