Re: [Review] pgbench duration option

ITAGAKI Takahiro wrote:
> ***************
> *** 29,36 ****
> --- 29,40 ----
> #include "postgres_fe.h"
>
> #include "libpq-fe.h"
> + #include "pqsignal.h"
>
> #include <ctype.h>
> + #include <signal.h>
> + #include <sys/time.h>
> + #include <unistd.h>
>
> #ifdef WIN32
> #undef FD_SETSIZE

sys/time.h and unistd.h are #included just a few lines after that, but
within a #ifndef WIN32 block. I don't think the patch added any
codepaths where we'd need those header files on Windows, so I presume
that was just an oversight and those two extra #includes can be removed?
I don't have a Windows environment to test it myself.

Also, should we be using pqsignal at all? It's not clear to me what it
is, to be honest, but there's a note in pqsignal.h that says "This
shouldn't be in libpq, but the monitor and some other things need it..."

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com