| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alex Hunsaker <badalex(at)gmail(dot)com>, Xiao Meng <mx(dot)cogito(at)gmail(dot)com>, pgsql-patches(at)postgresql(dot)org, "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com> |
| Subject: | Re: hash index improving v3 |
| Date: | 2008-09-08 14:20:15 |
| Message-ID: | 48C5349F.4080300@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane napsal(a):
> "Alex Hunsaker" <badalex(at)gmail(dot)com> writes:
>> On Fri, Sep 5, 2008 at 2:21 PM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
>>> Ok now that I made it so it actually *test* collisions, with the patch
>>> it always returns all rows that matched the hashed "key".
>
>> And here is the fix, we just forget to set the recheck flag for bitmap scans.
>
> For the convenience of anyone intending to test, here is an updated
> patch against CVS HEAD that incorporates Alex's fix.
>
Tom,
I attach cleanup patch which we discussed last commit fest. It introduce new
macros HashGetMetaPage and HashGetBitmap and of course, it break backward on
disk format compatibility which we will break it anyway when Xiao's patch will
be committed.
Zdenek
--
Zdenek Kotala Sun Microsystems
Prague, Czech Republic http://sun.com/postgresql
| Attachment | Content-Type | Size |
|---|---|---|
| hash_cleanup.patch | text/x-diff | 9.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark | 2008-09-08 14:27:43 | Re: [PATCH] Cleanup of GUC units code |
| Previous Message | Alvaro Herrera | 2008-09-08 14:17:56 | Re: [PATCH] Cleanup of GUC units code |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ryan Bradetich | 2008-09-08 14:46:56 | Re: [PgFoundry] Unsigned Data Types [1 of 2] |
| Previous Message | Zdenek Kotala | 2008-09-08 08:58:09 | Re: hash index improving v3 |