| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Karl Schnaitter <karlsch(at)soe(dot)ucsc(dot)edu> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: fixing bug in combocid.c |
| Date: | 2008-09-01 18:55:32 |
| Message-ID: | 48BC3AA4.7060804@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Karl Schnaitter wrote:
> This patch is for a bug in backend/utils/time/combocid.c.
>
> In HeapTupleHeaderAdjustCmax, the code makes the incorrect assumption
> that the raw command id corresponds to cmin, when the raw command id can
> in fact be a combo cid. It needs to be fixed to call
> HeapTupleHeaderGetCmin to get cmin. That's all there is to my patch, but
> read on for more details.
Yep. Patch committed.
Thanks for the report!
> This is my first patch; I hope I did it right!
You did well :-). No need to tar or gzip small patches like that, though.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2008-09-01 19:23:19 | Re: WIP Join Removal |
| Previous Message | Stephen Frost | 2008-09-01 13:49:22 | Re: Extending grant insert on tables to sequences |