Skip site navigation (1) Skip section navigation (2)

Re: gsoc, oprrest function for text search take 2

From: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
To: Jan Urbański <j(dot)urbanski(at)students(dot)mimuw(dot)edu(dot)pl>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Simon Riggs" <simon(at)2ndQuadrant(dot)com>,"Postgres - Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gsoc, oprrest function for text search take 2
Date: 2008-08-27 07:46:37
Message-ID: 48B5065D.6050702@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Jan Urbański wrote:
> Tom Lane wrote:
>> =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= <j(dot)urbanski(at)students(dot)mimuw(dot)edu(dot)pl> 
>> writes:
>>> Simon Riggs wrote:
>>>> put it in a file called selfuncs_ts.c so it is similar to the existing
>>>> filename?
>>
>>> I followed the pattern of ts_parse.c, ts_utils.c and so on.
>>> Also, I see geo_selfuncs.c. No big deal, though, I can move it.
>>
>> Given the precedent of geo_selfuncs.c, I think you were right the
>> first time.  A more interesting question is whether it should just
>> get folded into selfuncs.c ...
> 
> selfuncs.c is a 5.8k lines beast, I felt a bit intimidated when first 
> opened it. The code in ts_selfuncs.c relies strongly on what the code in 
> ts_typanalyze.c does and that was another reason for putting in in its 
> own file next to ts_typanalyze.c. I don't really care to be honest, 
> might as well stick it into selfuncs.c.

I would leave the code in ts_selfuncs.c like you did. The stuff in 
selfuncs.c is pretty generic, not related to any specific data type. 
With the exception of the regex and LIKE selectivity functions, but 
those should rather be moved to a separate file, say pattern_selfuncs.c. 
There's also plenty of datatype-specific code in convert_to_scalar() and 
its subroutines, but even the comment there says that it's a hack.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2008-08-27 13:05:54
Subject: Re: TODO <-> Commitfest
Previous:From: Grant FinnemoreDate: 2008-08-27 07:35:03
Subject: Re: Proposal to sync SET ROLE and pg_stat_activity

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group