Skip site navigation (1) Skip section navigation (2)

Re: Enabling SQL text field in the SQL tab of object dialog

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Date: 2008-08-26 17:44:53
Message-ID: 48B44115.3070609@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dave Page a écrit :
> On Wed, Jul 9, 2008 at 12:31 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> [...]
>> I prefer to add sizing to all (properties') dialogs. This is a work I can
>> do, step by step. I think I should follow these steps in this order:
>>
>>  * one patch for each dialog to add the sizing.
>>  * one patch to add sizing on common tabs (ie "Variables", "Privileges",
>>   and "SQL").
>>  * v5 patch for the read-write/read-only mode on sql textfields.
>>
>> OK for these steps?
> 
> Yup, sounds like a good plan to me.
> 

Back on this. The plan took a lot more time than I initially thought.
Anyways, here is the v5 patch updated.

This patch aims to allow changes on sql text fields. The checkbox need
to be checked to allow typing in the text fields. When checked, other
tabs are unavailable. When un-checked, a confirmation dialog aks the
user if he wants to loose his changes. If yes, it replaces changes with
the previous queries. If no, it keeps the checkbox checked.

It seems to me it's ready for commit.

Comments?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2008-08-26 17:48:26
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Previous:From: Dave PageDate: 2008-08-26 14:24:43
Subject: Re: Dialogs Review new patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group