Skip site navigation (1) Skip section navigation (2)

Re: Parsing of pg_hba.conf and authentication inconsistencies

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parsing of pg_hba.conf and authentication inconsistencies
Date: 2008-08-16 15:47:36
Message-ID: 48A6F698.50808@hagander.net (view raw or flat)
Thread:
Lists: pgsql-hackers
Bruce Momjian wrote:
> Magnus Hagander wrote:
>>> To address Magnus' specific question, right now we store the pg_hba.conf
>>> tokens as strings in the postmaster.  I am fine with storing them in a
>>> more native format and throwing errors for values that don't convert. 
>>> What would concern me is calling lots of 3rd party libraries from the
>>> postmaster to validate items.
>> If I was unclear about that, that part was never part of what I
>> proposed. I'm only talking aobut parsing the syntax. The only external
>> calls in the code there now is the getaddrinfo calls to convert the IPs,
>> IIRC.
> 
> That seems safe to me.  The use of strings for the pg_hba.conf content
> was only for convenience;  I can see the advantage of using a more
> natural format.

Attached is the patch I have so far. The only "extra" it adds over today
is that it allows the use of "ident" authentication without explicitly
specifying "sameuser" when you want that.

Other than that, it moves code around to do the parsing in the
postmaster and the maching in the backend. This means that now if there
is a syntax error in the file on a reload, we just keep the old file
around still letting people log into the database. If there is a syntax
error on server startup, it's FATAL of course, since we can't run
without any kind of pg_hba.

It also changes a couple of error cases to explicitly state that support
for a certain auth method isn't compiled in, rather than just call it a
syntax error.

Comments?

//Magnus

Attachment: hba_parse.patch
Description: text/x-diff (30.0 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-08-16 15:57:35
Subject: Re: Parsing of pg_hba.conf and authentication inconsistencies
Previous:From: Magnus HaganderDate: 2008-08-16 12:45:10
Subject: [Fwd: [COMMITTERS] pgsql: probes.h is generated from probes.d, not pg_trace.d.]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group