Re: Minimum height of server status dialog

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Minimum height of server status dialog
Date: 2008-08-01 09:36:53
Message-ID: 4892D935.7010002@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Guillaume Lelarge wrote:
>> The hotkey stuff I was working on already, but I'll just use your patch
>> instead. It seems to be working fine in on my machine as well, so I'll
>> go ahead and commit it. One thing first though...
>>
>> When I ran embed-xrc, I got a diff containing:
>> Index: ui/xrcDialogs.cpp
>> ===================================================================
>> --- ui/xrcDialogs.cpp (revision 7394)
>> +++ ui/xrcDialogs.cpp (working copy)
>> @@ -13,6 +13,14 @@
>> #include <wx/xrc/xmlres.h>
>> #include <wx/xrc/xh_all.h>
>>
>> +#if wxCHECK_VERSION(2,8,5) && wxABI_VERSION >= 20805
>> + #define XRC_ADD_FILE(name, data, size, mime) \
>> + wxMemoryFSHandler::AddFileWithMimeType(name, data, size, mime)
>> +#else
>> + #define XRC_ADD_FILE(name, data, size, mime) \
>> + wxMemoryFSHandler::AddFile(name, data, size)
>> +#endif
>> +
>>
>> Is that normal? Or am I using something that I shouldn't be using? Don't
>> want to do anything until that's confirmed :)
>>
>
> I don't have this on my "svn diff", but I do have these lines on my
> xrcDialog.cpp file. Are you sure your svn copy is uptodate ?

Ah, I get it. I get them in the svn diff in the *backbranch*, but not in
HEAD.... Are we using different versions of wx to build these two?

//Magnus

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2008-08-01 09:46:09 Re: Minimum height of server status dialog
Previous Message Guillaume Lelarge 2008-08-01 09:33:14 Re: Minimum height of server status dialog