Alvaro Herrera wrote:
> But I don't see a reason to define the rest:
>> +typedef unsigned int locktag_field2;
>> +typedef const char * query_string;
>> +typedef int sortType;
>> +typedef int trueFalse;
>> +typedef int nkeys;
>> +typedef int workMem;
>> +typedef int randomAccess;
>> +typedef unsigned long LogicalTapeSetPtr;
>> +typedef long spaceUsed;
>> +typedef int isLocalBuf;
>> +typedef int found;
>> +typedef int flags;
>> +typedef int num_to_write;
>> +typedef int num_written;
>> +typedef int NBuffers;
>> +typedef int buf_id;
> I think you should add a #define Size, perhaps #define bool, and use
> those where applicable, and the plain types (int, long, etc) in the rest.
Fixed. Patch attached.
> That Mac OS X problem merits some extra investigation, I think.
I'm investigating this one and will find the root cause, but I don't
think it should hold back this patch.
> Other than this, I think this patch can be committed.
I'd appreciate if it can be committed today.
Alvaro, thanks a bunch for the feedback!
Robert Lor Sun Microsystems
Austin, USA http://sun.com/postgresql
In response to
pgsql-hackers by date
|Next:||From: Alvaro Herrera||Date: 2008-07-31 20:43:30|
|Subject: Re: Review: DTrace probes (merged version) ver_03|
|Previous:||From: David Fetter||Date: 2008-07-31 20:06:07|
|Subject: Re: Fixing DISTINCT ON for duplicate keys|