Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] odd output in restore mode

From: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
To: "Martin Zaun" <Martin(dot)Zaun(at)Sun(dot)COM>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>,"Greg Smith" <gsmith(at)gregsmith(dot)com>,"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>,"Simon Riggs" <simon(at)2ndquadrant(dot)com>,"Bruce Momjian" <bruce(at)momjian(dot)us>,"Dave Page" <dpage(at)pgadmin(dot)org>,"PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>,"List pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] odd output in restore mode
Date: 2008-07-31 16:05:16
Message-ID: 4891E2BC.203@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Martin Zaun wrote:
> Heikki Linnakangas wrote:
>> Andrew Dunstan wrote:
>>> Greg Smith wrote:
>>>> On Wed, 23 Jul 2008, Kevin Grittner wrote:
>>>>
>>>> I've been working on an improved archive_command shell script that I 
>>>> expect to submit for comments and potential inclusion in the 
>>>> documentation as a better base for other people to build on. This is 
>>>> one of the options for how it can operate. It would be painful but 
>>>> not impossible to convert a subset of that script to run under 
>>>> Windows as well, at least enough to cover this particular issue.
>>>
>>> A Perl script using the (standard) File::Copy module along with the 
>>> builtin function rename() should be moderately portable. It would to 
>>> be nice not to have to maintain two scripts.
>>
>> It's also not very nice to require a Perl installation on Windows, 
>> just for a replacement of Copy. Would a simple .bat script work?
> 
> With these avenues to be explored, can the pg_standby patch on the
> CommitFest wiki be moved to the "Returned with Feedback" section?

Yes, I think we can conclude that we don't want this patch as it is. 
Instead, we want a documentation patch that describes the problem, 
mentioning that GNU cp is safe, or you can use the copy+rename trick.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-07-31 16:32:38
Subject: Re: [PATCHES] odd output in restore mode
Previous:From: Magnus HaganderDate: 2008-07-31 15:09:39
Subject: Re: Dumping datconfig

pgsql-patches by date

Next:From: Tom LaneDate: 2008-07-31 16:32:38
Subject: Re: [PATCHES] odd output in restore mode
Previous:From: chrisDate: 2008-07-30 18:58:51
Subject: Re: WIP: Transportable Optimizer Mode

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group